lxq/changes/n05-salary-calc/verification-report.md

N05 salary calculator verification report

Verification dimensions

Dimension	Status	Findings
Completeness	PASS	All 9 tasks checked; W1-W4 review receipts pass; 22 approved requirements have task coverage and implementation evidence.
Correctness	PASS	Salary*Test 24/24; disposable Docker MySQL 8.4 black-box PASS; Flyway V40/V41 and 359 city rows verified.
Coherence	PASS	Design decisions match code: current city policy + snapshots, BigDecimal engine, dataLevel propagation, idempotency, account-deletion cleanup.
Scope	WARN	Shared ErrorCode, security route and account-deletion worker changed as declared in the contract; no unrelated production files changed.
Full regression	WARN	mvn clean verify: 1516 tests, 2 failures / 9 errors, all in pre-existing non-salary modules.

Evidence

• mvn -Dtest=Salary*Test test -> 24 tests, 0 failures, 0 errors.
• python docs/verify_openapi.py -> 139 paths / 178 operations, all checks passed.
• Disposable Docker MySQL 8.4 + containerized backend black-box -> PASS.
• Flyway versions 40,41; city policy count 359; CITY=12; PROVINCE_FALLBACK=347.
• Temporary MySQL/backend containers and network destroyed after verification.
• Delta specs synced through ssf sync; publication receipt recorded.

Verdict

CONDITIONAL PASS for N05: all salary-calculator requirements, focused tests, OpenAPI checks and isolated MySQL black-box acceptance pass. The only release warning is the repository-wide pre-existing regression failures outside this change:

• CareerProgressServiceTest.fullAggregation_returnsCorrectSummaries
• JobReviewDimensionControllerTest.listReviews_shouldReturnDimensionScores
• JobReviewDimensionServiceTest.listReviews_shouldReturnDimensionScoresWithoutN1
• 9 LocalResumeStorageServiceTest extension-context errors

No salarycalculator tests fail. Closing requires explicit user acceptance of this conditional release outcome.