lxq/changes/n04-onboard/.superpowers/sdd/reviews/W3-T7.md

W3 T7 Review: Onboarding End-to-End and Gap Tests

Verdict

• Spec compliance: PASS
• Task quality: Approved
• Overall: PASS
• Base: 97b3b16
• Head: 73afd87
• Blocking findings: none
• Cannot verify from this task alone: real MySQL 8.4 execution remains a later verification-gate obligation.

Verification

• Read task-reviewer-prompt.md, writing-good-tests.md, the T7 brief, execution contract, both onboarding specs, the full 97b3b16..73afd87 diff, and the complete changed test files where the diff output was truncated.
• Scope check: git diff --name-only 97b3b16..73afd87 contains no mydreamjob-server/src/main/** files. The T7 implementation scope is limited to three test files plus workflow/review artifacts.
• Ran OnboardingEndToEndIntegrationTest,CompanyKnowledgeServiceTest,OnboardingRepositoryIntegrationTest: Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.
• Ran Onboarding*Test,CompanyKnowledge*Test: Tests run: 96, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.
• Ran OnboardingEndToEndIntegrationTest with JUnit random method ordering: Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, BUILD SUCCESS.
• Scoped git diff --check 97b3b16..73afd87 -- <three T7 test files> passed. Range-wide git diff --check reports two pre-existing blank lines at EOF in W2-T4.md and W2-T5.md, outside T7.

Spec Compliance

• All nine distinct onboarding paths are exercised through the full Spring context, MockMvc, JWT filter, H2 MODE=MySQL, repositories, and DTO serialization: OnboardingEndToEndIntegrationTest.java:82-212.
• Student fallback and merged-company behavior are covered: standard-only after soft deletion, customized=false, merged standard/company items, source values, completion count, and rate (:135-167, :202-208).
• Student absolute-state completion behavior is covered end to end: first completion, idempotent replay with a stale version, cancellation clearing completedAt, stale-version conflict, persisted row count, and unchanged state after conflict (:214-264).
• Company checklist behavior is covered end to end: list, create, idempotent replay, request-hash conflict, 50-active-item boundary, update, soft delete, repeated delete, cross-company update/delete isolation, and state preservation (:266-364).
• Company knowledge behavior is covered across BASIC_ONLY, CONFIGURED, EMPTY, exact two-review INSUFFICIENT, and SUFFICIENT, including absence of aggregates below three reviews (:366-441).
• Public-review filtering excludes HIDDEN and non-public moderation states from counts, tags, ratings, and dimension aggregates. Repository coverage is explicit at OnboardingRepositoryIntegrationTest.java:267-301; the E2E flow also adds hidden/pending records before asserting the visible totals and aggregates (OnboardingEndToEndIntegrationTest.java:410-440).
• Anonymous 401, wrong-role 403, and missing-company/item 404 paths are covered across the endpoint families, with database-state assertions after failures (OnboardingEndToEndIntegrationTest.java:443-543).
• Response privacy checks run for every success and error response and cover owner/student IDs, moderation reason, request/content/identity hashes, IP/User-Agent, password/token fields, phone, email, and idempotency keys (OnboardingEndToEndIntegrationTest.java:545-577).
• The focused service tests cover the exact two-review threshold, all eight dimension summaries, deterministic tag top-ten limiting, and recursively quoted JSON tags (CompanyKnowledgeServiceTest.java:292-358).

Test Falsifiability

• The E2E tests assert externally observable HTTP status, response JSON, persisted row state, and cross-company ownership effects. They would fail for incorrect routing, authorization, fallback, merging, version handling, soft-delete behavior, or aggregate filtering.
• The threshold tests independently assert the absence of aggregates at zero, one, and two public reviews, and their presence at three. A change to the threshold or query filtering would fail them.
• The repository test independently verifies PUBLISHED plus approved moderation filtering and excludes HIDDEN records from all aggregate queries. A filter regression would fail the counts, tags, and dimension sample assertions.
• The privacy helper checks serialized response bodies rather than trusting service DTO construction alone.
• The randomized-order E2E run passed without reliance on wall-clock precision, external services, or test-order state.

Strengths

• The new E2E test uses the real application context and persistence layer, not mocked controllers or repositories.
• Error-path state preservation is asserted at the database level, not only through HTTP status codes.
• The coverage combines a broad endpoint contract flow with focused service/repository tests for threshold, tag, and moderation-filter edge cases.
• No production files were changed; the task stayed within the intended test-hardening scope.

Issues

Critical (Must Fix)

None.

Important (Should Fix)

None.

Minor (Nice to Have)

• OnboardingEndToEndIntegrationTest.java:82-212 combines success checks for all nine endpoints into one long flow. It is correct, but a failure gives a broad diagnosis surface. Splitting the endpoint families into smaller E2E tests would improve failure isolation without changing behavior.
• OnboardingEndToEndIntegrationTest.java:559-576 checks sensitive fields with raw serialized-string substrings. It covers the named fields in the current contract, but a recursive JSON field-name check would be more robust if DTO serialization changes or sensitive data is nested under a renamed field.
• Tag top-ten limiting and recursively quoted JSON parsing are covered at the service layer (CompanyKnowledgeServiceTest.java:314-358), while the E2E flow only exercises the three-tag sufficient case (OnboardingEndToEndIntegrationTest.java:425-434). This is acceptable for T7 because the focused behavior is covered, but retaining an HTTP-level edge case would provide broader integration evidence.
• Non-T7 range artifact: git diff --check 97b3b16..73afd87 reports blank lines at EOF in W2-T4.md:94 and W2-T5.md:75. The three T7 test files themselves pass git diff --check.

Residual Verification Warning

• Real MySQL 8.4 behavior has not been run in this environment. H2 MODE=MySQL passed; MySQL/Docker black-box verification remains owned by the later verification gate.
• The prior T6 observation about knowledge-service lock-timeout/deadlock exception mapping remains outside T7 and was not modified here.

Assessment

Task quality: Approved

Reasoning: The T7 additions provide real full-context coverage for all nine endpoints, the required fallback, idempotency, concurrency-conflict, threshold, filtering, authorization, privacy, and state-preservation behaviors. The focused and full required suites, plus randomized ordering, all pass, and no production files were changed.

Controller receipt command when ssf is available:

ssf execution review changes/n04-onboard --wave W3 --base 97b3b16 --head 73afd87 --report changes/n04-onboard/.superpowers/sdd/reviews/W3-T7.md --verdict pass