# W3-T8 Re-review: OpenAPI 示例与默认值修复

- Wave: W3
- Task: T8
- Review round: repair round 1
- Base SHA: `aad0ba6`
- Head SHA: `310d931`
- Prior failed report: `W3-T8.md`
- Repair brief: `T8-repair-1.md`
- Verdict: **PASS**

## Original Findings

### Resolved: knowledge Upsert response example omitted `version`

`docs/openapi-rc.json:7439` now includes `data.version: 2` in the `PUT /onboarding/company/knowledge` 200 example. The request example uses `version: 1`, so the returned `version: 2` is consistent with update semantics. `CompanyKnowledgeView` still exposes `version`, and the schema remains unchanged.

### Resolved: create-item schema omitted runtime defaults

`docs/openapi-rc.json:11718` now declares `sortOrder.default = 1000`.
`docs/openapi-rc.json:11724` now declares `required.default = false`.
These match the initialized runtime fields in `CompanyChecklistItemCreateRequest`.

### Resolved: verifier did not assert the repaired contract

`docs/verify_openapi.py:300-309` now asserts:

- `CompanyChecklistItemCreateRequest.sortOrder.default == 1000`
- `CompanyChecklistItemCreateRequest.required.default is False`
- knowledge Upsert 200 example `data.version == 2`

The verifier diff adds 12 lines and removes none. Existing path, operation, schema, security, response-reference, field, and error-code checks remain intact, so the prior checks were not weakened.

## Scope Verification

The scoped semantic OpenAPI diff contains exactly the three intended changes:

- `CompanyChecklistItemCreateRequest.required.default`: added `false`
- `CompanyChecklistItemCreateRequest.sortOrder.default`: added `1000`
- knowledge Upsert 200 example `data.version`: added `2`

No runtime Java, test, migration, endpoint, schema, security, or unrelated documentation changes are present in `aad0ba6..310d931`.

## Evidence

```text
python .\docs\verify_openapi.py
paths: 135
N04 onboarding endpoints and schemas present (9 operations / 6 paths)
No empty ref keys found
Valid JSON: True
All checks passed!
```

```text
mvn -Dtest=Onboarding*Test,CompanyKnowledge*Test test
Tests run: 96, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS
```

`git diff --check aad0ba6..310d931` passed.

## Remaining Findings

No blocking findings.

Non-blocking carried-forward findings from the prior review remain outside this focused repair:

- Error-code verification remains partly text-based rather than asserting exact operation/status/example structure.
- Success responses continue to use the repository's existing `*/*` media type instead of explicit `application/json`.
- Full `mvn clean verify` and real MySQL 8.4 / Docker acceptance remain pending; the previously identified full-suite failures are unrelated to N04/T8.

## Assessment

**Ready for T8 receipt:** Yes

The two original Important findings are resolved, and both are now protected by exact verifier assertions without weakening earlier checks.

Receipt command:

```bash
ssf execution review changes/n04-onboard --wave W3-T8 --base aad0ba6 --head 310d931 --report .superpowers/sdd/reviews/W3-T8-rereview.md --verdict pass
```